Add CMake build mode flags to hdf5lib.settings #4816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build mode flags for things like optimization are not added to CMAKE_C_FLAGS and were not exported to the libhdf5.settings file. This change corrects that. Also removes -Og from the developer mode flags since that's already set via the debug flags the developer mode is based on.
derobins
added
Merge - To 1.14
Priority - 2. Medium ⏹
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
commented
Sep 7, 2024
| # that collect debugging information | ||
| set (CMAKE_C_FLAGS_DEVELOPER "${CMAKE_C_FLAGS_DEBUG} -Og" CACHE STRING | ||
| # Set CMake C flags based off of Debug build flags | ||
| set (CMAKE_C_FLAGS_DEVELOPER "${CMAKE_C_FLAGS_DEBUG}" CACHE STRING |
There was a problem hiding this comment.
This is already set in the debug flags
There was a problem hiding this comment.
This is CMAKE_C_FLAGS_DEBUG, which will only capture the debug flags that are added by default by CMake, or explicitly added at configure time by the user. Not the flags that we add separately in the library's configuration.
There was a problem hiding this comment.
That said, some compilers don't have -Og, so this does need to be refactored at some point, but I still find it useful.
byrnHDF
reviewed
Sep 9, 2024
| # H5build_settings.c | ||
| #----------------------------------------------------------------------------- | ||
| set (HDF5_BUILD_MODE_C_FLAGS "") | ||
| set (HDF5_BUILD_MODE_Fortran_FLAGS "") |
There was a problem hiding this comment.
Shouldn't the Fortran and CXX flags be set in the HDFFortranCompilerFlags.cmake and HDFCXXCompilerFlags.cmake files?
mattjala
requested changes
Oct 1, 2024
byrnHDF
added a commit
to byrnHDF/hdf5
that referenced
this pull request
Oct 18, 2024
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Oct 31, 2024
* Split CMake HDFCompileFlags into specific compiler files * Separate out CXX Flags * Add Fortran compiler specific files * Merge in HDFGroup#4816 changes and close HDFGroup#4816 * fix hanging endif --------- Co-authored-by: Larry Knox <lrknox@hdfgroup.org>
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Nov 4, 2024
* Split CMake HDFCompileFlags into specific compiler files * Separate out CXX Flags * Add Fortran compiler specific files * Merge in HDFGroup#4816 changes and close HDFGroup#4816 * fix hanging endif --------- Co-authored-by: Larry Knox <lrknox@hdfgroup.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags from the CMake build mode (e.g., optimization) are not a part of
CMAKE__FLAGS and were not exported to the libhdf5.settings file. This
has been fixed and the C, Fortran, and C++ build mode flags are now exported to
the file.
This also affects the text output of H5check_version() and the libhdf5.settings
string stored in the library (for those who use strings(1), etc. to get
build info from the binary).