Add pre-built list of neighborhood Targets to each node #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 552682360
💛 - Coveralls |
jya-kmu
reviewed
Feb 9, 2021
src/metadata_management.cc
Outdated
| @@ -975,4 +975,80 @@ void DecrementRefcount(SharedMemoryContext *context, RpcContext *rpc, | |||
| } | |||
| } | |||
|
|
|||
| u32 GetRelativeNodeId(RpcContext *rpc, int offset) { | |||
| int result = rpc->node_id + offset; | |||
| CHECK_GE(result, 0); | |||
There was a problem hiding this comment.
Is it fine to abort here if check failed?
There was a problem hiding this comment.
I believe so. Since this is an internal developer interface, the check is here to prevent developer errors. In that case, I prefer to fail as fast as possible. Maybe an assert would be better since it's intended as a developer check.
There was a problem hiding this comment.
I changed it to assert.
jya-kmu
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76.
Targets to each node that consists of the localTargets fromnode_id- 1 andnode_id+ 1 (wrapping around). This is a temporary definition of a neighborhood. In the future aTopologyManagerwill decide how neighborhoods are built.LocalGetNeighborhoodTargets. Unfortunately we can't create automated tests for it until we resolve Automated cluster testing #116.