Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move blob loop from VBucket::Attach to PersistTrait #233

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Move blob loop from VBucket::Attach to PersistTrait #233

merged 1 commit into from
Oct 14, 2021

Conversation

ChristopherHogan
Copy link
Collaborator

Looping through each Blob is a choice the onAttach callback of each Trait should make rather than doing it for all Traits in VBucket::Attach.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 81.293% when pulling dba58bf on chogan/onattach into 8331bda on master.

@ChristopherHogan ChristopherHogan merged commit c2ba3b3 into master Oct 14, 2021
@ChristopherHogan ChristopherHogan deleted the chogan/onattach branch October 14, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jya-kmu jya-kmu jya-kmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristopherHogan @coveralls @jya-kmu