Support relative paths and symlinks in adapters #309

ChristopherHogan · 2021-12-17T20:11:38Z

Fixes #179, fixes #180.

Expand all paths intercepted by adapters into their "canonical" forms, which means resolve all symlinks, remove any extra slashes, and resolve all instances of . and ...
The C++17 filesystem library provides the function filesystem::weakly_canonical, which expands paths (both existent and non-existent) as described above. However, it is only available in gcc >= 9. In order to continue supporting gcc 7 (the version installed on the Ares cluster), I've ported weakly_canonical from libstdc++ into hermes.

coveralls · 2021-12-17T20:36:26Z

Coverage increased (+0.4%) to 81.046% when pulling 18e8556 on chogan/adapter_paths into 3029073 on master.

ChristopherHogan added 4 commits December 15, 2021 13:42

Support symlinks and relative paths in adapters

f8a4c3a

Appease linter

8a6a349

Don't use GLOG until after PopulateBufferingPath has been called

f0c98aa

Backport gcc 9's weakly_canonical so we can still support gcc 7

18e8556

ChristopherHogan merged commit 9bf5458 into master Dec 17, 2021

ChristopherHogan deleted the chogan/adapter_paths branch December 17, 2021 20:37

ChristopherHogan added the enhancement New feature or request label Dec 17, 2021

Provide feedback