Move docker files to folder and add CI step to publish docker images #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyoklee
reviewed
Mar 3, 2022
.github/workflows/main.yml
Outdated
| @@ -92,3 +94,38 @@ jobs: | |||
| uses: coverallsapp/github-action@master | |||
| with: | |||
| github-token: ${{ secrets.GITHUB_TOKEN }} | |||
| build-docker-images: | |||
| if: ${{ github.ref_type == 'tag' || github.event.inputs.build_docker_images }} | |||
| runs-on: ubuntu-20.04 | |||
There was a problem hiding this comment.
Use ubuntu-latest so we don't have to update it when a new Ubuntu release comes out.
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #290. Closes #291.
This change enables automatically building docker images and pushing them to dockerhub every time we tag a new release. I've also added a way to force the images to be built and uploaded via the
build_docker_imagesworkflow dispatch option.