Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Write Hyperslab from Memory #57

Closed
wants to merge 4 commits into from
Closed

Fix Write Hyperslab from Memory #57

wants to merge 4 commits into from

Conversation

mattjala
Copy link
Collaborator

This is #50 with an additional check to avoid allocating the buffer and performing H5Dgather if the memory selection is already contiguous.

jwsblokland and others added 4 commits August 25, 2023 14:41
@jwsblokland
rest_vol_dataset: (fix) Write hyperslab (memory)
823e090 
- Improved the function RV_dataset_write() such it makes use
  of the function H5Dgather() to gather the data needed
  for writing a hyperslab (memory) to a file. This approach
  is similar to the one found in the function RV_dataset_read().
- Adapted the hyperslab and point selection test.
@mattjala
Only H5Dgather on non-contiguous write
9c7e369
@github-actions
Committing clang-format changes
47fea27
@mattjala
Merge branch 'HDFGroup:master' into blokland_hyperslab
bdce543
@mattjala mattjala added the bug Something isn't working label Aug 30, 2023
@mattjala mattjala mentioned this pull request Aug 30, 2023
Closed
@jwsblokland
Copy link
Contributor

jwsblokland commented Aug 31, 2023 •
edited
Loading

@mattjala I just noticed your work on improving the memory-side hyperslab for writing. The interesting thing is I also just finished a similar improvement. I will create a PR of it such you can take a look at it. Maybe we need to combine both PRs to get the best solution.

Update: my PR is #58

@jwsblokland jwsblokland mentioned this pull request Aug 31, 2023
Merged
@mattjala mattjala closed this Aug 31, 2023
@mattjala mattjala deleted the blokland_hyperslab branch September 6, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjala @jwsblokland