Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 144 remove demo folder #148

Merged
merged 12 commits into from
Jul 4, 2019
Merged

Issue 144 remove demo folder #148

merged 12 commits into from
Jul 4, 2019

Conversation

pvk-developer
Copy link
Member

  • atm get_demos returns a full list of the datasets available in our public bucket.
  • atm download_demo <name of dataset> downloads a dataset (or a list of datasets).
  • Also available in python with data.get_demos, returns a list, and data.download_demo returns the path to the saved dataset (or a list with paths if we requested a list of datasets).

Resolve #144

@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #148 into master will increase coverage by 2.02%.
The diff coverage is 73.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   63.31%   65.34%   +2.02%     
==========================================
  Files          15       15              
  Lines        1723     1760      +37     
==========================================
+ Hits         1091     1150      +59     
+ Misses        632      610      -22
Impacted Files Coverage Δ
atm/cli.py 17.92% <50%> (+17.92%) ⬆️
atm/data.py 67.74% <91.66%> (+8.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb8b54d...0aa7605. Read the comment docs.

@csala csala merged commit 7ed5a41 into master Jul 4, 2019
@csala csala deleted the issue-144-remove-demo-folder branch July 25, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove demos folder and download them from S3
3 participants