Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for multi authors taxonomies #98

Merged
merged 12 commits into from
Jun 8, 2021

Conversation

xqbumu
Copy link
Contributor

@xqbumu xqbumu commented Jun 7, 2021

feat: add multi authors
feat(authors): add link
docs: add authors

with feature: #96

feat(authors): add link

docs: add authors
@xqbumu xqbumu changed the title feat: add multi authors support [FEATURE] Add support for multi authors taxonomies Jun 7, 2021
@HEIGE-PCloud HEIGE-PCloud self-requested a review June 7, 2021 06:18
@HEIGE-PCloud HEIGE-PCloud added the enhancement Enhance existing features label Jun 7, 2021
@HEIGE-PCloud HEIGE-PCloud added this to the v0.2.12 milestone Jun 7, 2021
@HEIGE-PCloud HEIGE-PCloud linked an issue Jun 7, 2021 that may be closed by this pull request
3 tasks
Copy link
Owner

@HEIGE-PCloud HEIGE-PCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author field in RSS file is not updated.

For example, in /categories/tests/index.xml

<item>
<title>Author single test</title>
<link>http://localhost:1313/author-single-tests/</link>
<pubDate>Mon, 07 Jun 2021 08:46:10 +0100</pubDate>
<author>PCloud</author>
<guid>http://localhost:1313/author-single-tests/</guid>
<description>
<![CDATA[ <p>Just for authors test.</p> ]]>
</description>
</item>

Items have incorrect author.

@xqbumu
Copy link
Contributor Author

xqbumu commented Jun 7, 2021

The author field in RSS file is not updated.

For example, in /categories/tests/index.xml

<item>
<title>Author single test</title>
<link>http://localhost:1313/author-single-tests/</link>
<pubDate>Mon, 07 Jun 2021 08:46:10 +0100</pubDate>
<author>PCloud</author>
<guid>http://localhost:1313/author-single-tests/</guid>
<description>
<![CDATA[ <p>Just for authors test.</p> ]]>
</description>
</item>

Items have incorrect author.

多作者的情况下rss该怎么处理,当时没的搜到相关内容,所以就按默认的处理了,你这样有了解相关的东西吗?

晚点我再研究下。

或者以 author 作为第一优先级,不存在则取第一个authors,最后取 config的作者。

或者以

<author>author1@example.org (author1), author2@example.org (author2)</author>

方式处理。

@HEIGE-PCloud
Copy link
Owner

HEIGE-PCloud commented Jun 7, 2021

RSS 标准中本不包含 <author> 字段,但大多数阅读器都对 <author> 有支持,但支持的程度不同。我倾向于遵守 Atom 1.0 的标准来处理 <author>。当有多个作者时,按照以下格式处理。

<author>
    <name>Author 1</name>
    <uri>http://example.org/</uri>
    <email>author1@example.com</email>
</author>
<author>
    <name>Author 2</name>
    <uri>http://example.org/</uri>
    <email>author2@example.com</email>
</author>

但不同阅读器可能对于这个格式会有不同的处理方式,可能只显示第一个或最后一个,这个就交给用户和阅读器来做选择了。

@xqbumu
Copy link
Contributor Author

xqbumu commented Jun 7, 2021

The author field in RSS file is not updated.
For example, in /categories/tests/index.xml

<item>
<title>Author single test</title>
<link>http://localhost:1313/author-single-tests/</link>
<pubDate>Mon, 07 Jun 2021 08:46:10 +0100</pubDate>
<author>PCloud</author>
<guid>http://localhost:1313/author-single-tests/</guid>
<description>
<![CDATA[ <p>Just for authors test.</p> ]]>
</description>
</item>

Items have incorrect author.

多作者的情况下rss该怎么处理,当时没的搜到相关内容,所以就按默认的处理了,你这样有了解相关的东西吗?
晚点我再研究下。
或者以 author 作为第一优先级,不存在则取第一个authors,最后取 config的作者。
或者以

<author>author1@example.org (author1), author2@example.org (author2)</author>

方式处理。

RSS 标准中本不包含 <author> 字段,但大多数阅读器都对 <author> 有支持,但支持的程度不同。我倾向于遵守 Atom 1.0 的标准来处理 <author>。当有多个作者时,按照以下格式处理。

<author>
    <name>Author 1</name>
    <uri>http://example.org/</uri>
    <email>author1@example.com</email>
</author>
<author>
    <name>Author 2</name>
    <uri>http://example.org/</uri>
    <email>author2@example.com</email>
</author>

但不同阅读器可能对于这个格式会有不同的处理方式,可能只显示第一个或最后一个,这个就交给用户和阅读器来做选择了。

好的

Copy link
Owner

@HEIGE-PCloud HEIGE-PCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否可以统一将 author 页面的 RelPermalink 设置为作者的 id?

exampleSite/data/authors/PCloud.toml Outdated Show resolved Hide resolved
layouts/taxonomy/terms.html Show resolved Hide resolved
layouts/partials/meta/author.html Outdated Show resolved Hide resolved
Copy link
Owner

@HEIGE-PCloud HEIGE-PCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Animation

主页上的链接好像全挂了,不知道改了啥,还是我的环境问题?

feat: add style for authors page
Copy link
Owner

@HEIGE-PCloud HEIGE-PCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大功告成!

你看看还有没有什么问题,或者需要修改和补充的,然后就可以合并了 😊

@xqbumu
Copy link
Contributor Author

xqbumu commented Jun 8, 2021

大功告成!

你看看还有没有什么问题,或者需要修改和补充的,然后就可以合并了 😊

可以 squash 下后再合并,然后就没什么问题了。

@HEIGE-PCloud HEIGE-PCloud merged commit 73b24e0 into HEIGE-PCloud:main Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 添加多作者分类
2 participants