Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix requirements range error for travis test #104

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

ccnifo
Copy link
Collaborator

@ccnifo ccnifo commented Feb 22, 2019

Set correct parsable ranges on module requirements to pass Travis tests

@ccnifo
Copy link
Collaborator Author

ccnifo commented Feb 25, 2019

@kreczko : I saw that stdlib 5.2.0 is available, maybe we can test it to enlarge the supported version range? Release notes for 5.0.0 say:

This is a major release which removes support for the Scientific 5 and Debian 7 OS, as well as a removal of the Stdlib::(Ipv4|IPv6|Ip_address) data types in favour of Stdlib::IP::*.

@kreczko
Copy link
Member

kreczko commented Feb 25, 2019

sure, let's try it

@kreczko kreczko mentioned this pull request Feb 25, 2019
@ccnifo
Copy link
Collaborator Author

ccnifo commented Feb 25, 2019

I ran a pass with stdlib 5.2.0 on my CentOS7 cluster, no warning whatsoever on worker, master, or scheduler. Of course, one can have a different experience on a different cluster.

@ccnifo
Copy link
Collaborator Author

ccnifo commented Mar 1, 2019

@kreczko and I've seen no mention of stdlib::ip in the module, so I guess we're OK? Would you prefer to merge as is or to include 5.x?

@ccnifo
Copy link
Collaborator Author

ccnifo commented Apr 23, 2019

@kreczko : re-reading the release notes of stdlib 5.0.0 makes me thing it should run fine.
However, 1 or 2 module users testing it would be great!

@kreczko kreczko merged commit 5507396 into HEP-Puppet:master Apr 23, 2019
@ccnifo ccnifo deleted the fix_travis branch May 15, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants