Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute DE as whl with proper dependencies and install other system dependencies as RPM #695

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

vitodb
Copy link
Contributor

@vitodb vitodb commented Dec 7, 2023

This PR adds the spec file with RPM dependencies for DE and the setup to build DE whl.

Some notes:

  • This spec file is derived from the spec file we got from setup.py
  • To properly set the RPM version the rpmbuild command needs to be executed from inside the decisionengine repo folder.
  • Among dependencies we have build tools, those are needed because the jsonnet python module needs to be built from source.
  • podman is needed to run redis server 6 container.
  • The %description section could need to be reviewed, it has couple of lines commented out that probably were intended to be section header.
  • To install the RPM obtained from this spec file, it is needed to enable CRB repo, as there are dependencies from that repo.
  • following folders owned by decisionengine are created:
    /etc/decisionengine/
    /var/log/decisionengine/
    /var/lib/decisionengine/
    and configuration file /etc/decisionengine/decision_engine.jsonnet is included
  • Jenkins pipeline and GH actions have been updated to build DE whl and RPM with DE dependencies
  • Jenkins pipeline and GH action that build RPM from setup.py have been removed

Dependencies not included:

  • postgresql postgresql-server:
    Currently we have a version of postgresql RPM from EL9 repo compatible with DE, with EL7 we needed to pick a postgresql version from official postgresql repositories.
  • htgettoken:
    We need this to create scitokens. This is need for integration tests, but is not a real DE requirement.

Other improvement that could be added are:

  • set decisionengine as owner of /var/lib/gwms-frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant