Check file size less than UPLOAD_MAX_SIZE #332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've increased the
DEFAULT_TIMEOUT
for thehepdata-cli
package to allow for the increased request timeout in the Kubernetes settings from 1 minute to 5 minutes. I've also added a check to thehepdata-cli
code that the uploaded file size does not exceedUPLOAD_MAX_SIZE
. However, this limit could easily be modified in client-side code, so the check should also be made in the server-side code. Currently, we only make theUPLOAD_MAX_SIZE
check for web uploads and not for CLI uploads. This PR modifiesprocess_payload
to make the check for both. Alternatively, the Flask MAX_CONTENT_LENGTH could be set, but this did not return an informative error message when I tried it. I've written a new testtest_upload_max_size
intests/records_test.py
.