Display data license #745
Merged
Display data license #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the data licence information to the get_details function and process_resource functions in records/views.py to allow for passing of licence data.
Updates the table section in the records page, and the additional resources widget on the same page to display licence information for the current resource/table.
Update test_upload_max_size to use a regex to avoid breaking should TestHEPSubmission.zip change size.
Adds data licence information to the resource landing page display
* ctx.record.title is not defined for a Sandbox record.
Adds the text "Licence: " to the record page display for a table.
Fixes a bug where records page licence text wasn't clearing. This caused table refreshes to append an extra url to the element instead of clearing and appending.
Adds the text "Licence: " to the resource landing page data licence section.
Updates table render code to append licence url to use updated class names
Adds the a button to the landing_page version of a resource to the resource widget code and header text. Also adds css.
Fixes a test (test_home) broken by licence data changes.
Updates the resource widget download button text to be more accurate.
Fixes missing indentation in resource_details.html
Updates the resource record test in test_records.py to include a check for the licence
Fixes landing button text
Updates record page resource widget licence url text to be a lighter colour (lightblue)
* Set file_contents to the URL (instead of '') in the JSON metadata. * Redirect to the URL if the resource is viewed with "view=true".
GraemeWatt
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #740, closes #744. Updates record page to show licence information in the table section. Also displays record licence information on the additional resources widget and resource landing page. Adds a button link to the landing page to the additional resources widget.