-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table to track observations run through RTP #538
Conversation
Codecov Report
@@ Coverage Diff @@
## main #538 +/- ##
==========================================
+ Coverage 96.69% 96.77% +0.07%
==========================================
Files 34 34
Lines 4787 4893 +106
==========================================
+ Hits 4629 4735 +106
Misses 158 158
Continue to review full report at Codecov.
|
We also need to update the M&C definition tex doc to include this new table. |
@plaplant We're reviewing this in the commissioning meeting to try and get it online soon as we can. Some questions that came up:
|
@dannyjacobs to answer your questions:
I'll address the other comments on this PR later today. |
@plaplant Are we going to have a daemon on the commissioning repo that calls the launch script once per day at the right time? or is it going to be a cronjob? |
I've added a rough description of this change to http://hera.pbworks.com/w/page/118389669/Real-Time%20Processor. The script and table names are not correct, but its a start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I'm merging this now, but not installing on site yet. @plaplant will do that when he has time (remember to update/restart all the things listed in the readme!) |
This PR adds a new table (
RTPLaunchRecord
) which keeps track of observations that have been run through RTP. So far the PR defines the new table, and methods to add records and update them.Still needed are scripts to do this from the command line, as well as a related cron job to automatically launch jobs for recent observations.Scripts for adding/updating entries and launching RTP have been added in a834d77 and 0a57a8e.There are also some incidental changes around deprecated numpy datatypes, which seemed like such a small change that I lumped them into this PR.
Closes #527.