-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tag column to the hera_obs table #618
Conversation
Codecov Report
@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 98.14% 98.22% +0.08%
==========================================
Files 35 35
Lines 5123 5130 +7
==========================================
+ Hits 5028 5039 +11
+ Misses 95 91 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bhazelton! I think this looks great. I just have a question and found a few print statements that should be removed.
We should also change mc_add_observation.py
to add the tag to the observation when it's first added to M&C. I can make that change as part of this PR.
505b86d
to
937af4b
Compare
remove print cruft
937af4b
to
308e027
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @bhazelton! Merging this in so we can do a rebase for the forthcoming PR.
Description
Add a
tag
column to thehera_obs
table.Note: As currently written, the
create
classmethod on theObservation
object and theadd_obs
method onMCSession
requirestag
to be passed. So we will need to update RTP to pass it. The column is actually allowed to be null in the database, though, because all the old data do not have tags. I think long term we want RTP to set thetag
field, but if it would be easier short term I can make that an optional parameter.Motivation and Context
closes #605
Types of changes
Checklist:
Schema change:
changes when this is merged.