Mini snap make folders #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #620 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 35 35
Lines 5130 5130
=======================================
Hits 5035 5035
Misses 95 95 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bhazelton
reviewed
Aug 10, 2022
|
|
||
| folder_name = f"{int(np.floor(date)):d}" | ||
|
|
||
| # make the fold for the JD if it does not exist |
| folder_name = f"{int(np.floor(date)):d}" | ||
|
|
||
| # make the fold for the JD if it does not exist | ||
| folder = Path(args.outdir) / folder_name |
There was a problem hiding this comment.
I assume this works, I would normally use os.path.join myself.
There was a problem hiding this comment.
Yeah I like the object based interface for the pathlib.Path object. It does resolve to os.path.join eventually I bet.
bhazelton
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organizes the mini-snap catcher to write data to folders based on the JD.
Tried to sure up some logic to reduce the amount of logger warnings about data timeouts.
On site verified that data is written to the expected folders but haven't verified the logger is any less talkative yet (currently taking data at time of writing).