Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for compatibility with pyuvdata 3.0 and numpy 2.0 #669

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Jun 21, 2024

Description

  • Fix for some imports that will be changing in pyuvdata v3.0
  • Also switch from psycopg2 to psycopg3 (package is actually called psycopg) for numpy 2.0 compatibility. This requires sqlalchemy>=2.0 and python>=3.10
  • Update other dependencies as needed
  • Drop testing against python 3.8 & 3.9, add testing against 3.11 & 3.12

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Schema change (any change to the SQL tables)
  • New feature without schema change (non-breaking change which adds functionality)
  • Change associated with a change in redis structure
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change
  • Build or continuous integration change
  • Other

Checklist:

Other:

  • My code follows the code style of this project.
  • I understand the updates required onsite (detailed in the readme) and I will make those
    changes when this is merged.
  • Unit tests pass on site (This is a critical check, CI can differ from site).
  • I have updated the CHANGELOG.

@bhazelton bhazelton added the bug label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (056628a) to head (8688691).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   98.26%   98.28%   +0.02%     
==========================================
  Files          34       34              
  Lines        5304     5308       +4     
==========================================
+ Hits         5212     5217       +5     
+ Misses         92       91       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhazelton bhazelton changed the title Fix for compatibility with pyuvdata v3.0 Fix for compatibility with pyuvdata 3.0 and numpy 2.0 Nov 7, 2024
This warning doesn't show up except when running pytest with the `-W error` option. It's handled and doesn't indicate a real problem.
It's quite unpredictable which test it will happen in.

Also try to use context managers as much as possible and fix a couple other test issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant