Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update md5 to use hashlib or other standard module #187

Closed
mkolopanis opened this issue Feb 13, 2019 · 2 comments
Closed

update md5 to use hashlib or other standard module #187

mkolopanis opened this issue Feb 13, 2019 · 2 comments

Comments

@mkolopanis
Copy link
Member

mkolopanis commented Feb 13, 2019

as per PEP memo https://www.python.org/dev/peps/pep-0004/ the md5 module is depreciated and should be replaced with hashlib. This is also required for conversion to python 3 in issue #131

@mkolopanis
Copy link
Member Author

ah I'm also noticing now that the function which uses the module claims itself to be depreciated

def hash(w):
"""
Return an MD5 hash of a set of weights.
"""
DeprecationWarning("utils.hash is deprecated.")
return md5.md5(w.copy(order='C')).digest()

@philbull
Copy link
Collaborator

philbull commented Mar 5, 2019

I have removed this function in PR #189.

@philbull philbull closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants