-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: reuse splines on UVBeam objects #45
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 98.63% 98.66% +0.03%
==========================================
Files 5 5
Lines 292 300 +8
Branches 58 59 +1
==========================================
+ Hits 288 296 +8
Misses 1 1
Partials 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good @steven-murray. I approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, though I would like to see the test I request. You mentioned that this now depends on a pyuvdata
PR that hasn't been merged yet, but I don't quite see how. Could you explain? Is it the check_azza_domain
kwarg?
Edit: it looks like some tests are failing due to the number of beam pixels being even, so that should be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good @steven-murray . Just one comment that might be unnecessary. I have approved.
Re-uses splines when using
beam_list
instead ofbm_cube
. This should give a healthy speedup.