Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check shape of hkl array before write #400

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Check shape of hkl array before write #400

merged 1 commit into from
Feb 12, 2022

Conversation

saransh13
Copy link
Member

@saransh13 saransh13 commented Feb 11, 2022 •
edited by psavery
Loading

only write hkl if shape is not (0,).

Fixes: HEXRD/hexrdgui#1154

@saransh13 saransh13 mentioned this pull request Feb 11, 2022
Closed
psavery
psavery approved these changes Feb 11, 2022
View reviewed changes
Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also tested it and this fixed the issue.

@saransh13 saransh13 merged commit ec9d5b1 into master Feb 12, 2022
@psavery psavery deleted the hkl-shape-check branch February 14, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psavery psavery psavery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Materials and state save is broken
2 participants
@saransh13 @psavery