Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate atom sync #450

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Remove duplicate atom sync #450

merged 2 commits into from
Jun 18, 2022

Conversation

saransh13
Copy link
Member

sync Material.atominfo, Material.atomtype and Material.charge to the updated values after Material.remove_duplicate_atoms is called.

@saransh13 saransh13 mentioned this pull request Jun 17, 2022
Merged
psavery
psavery approved these changes Jun 18, 2022
View reviewed changes
Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saransh13 saransh13 merged commit ddb86df into master Jun 18, 2022
@saransh13 saransh13 deleted the remove-duplicate-atom-sync branch June 18, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psavery psavery psavery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saransh13 @psavery