Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for gvec_to_xy #613

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Add a test for gvec_to_xy #613

merged 2 commits into from
Jan 31, 2024

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Jan 31, 2024

Test data was taken from here.

@pep8speaks
Copy link

pep8speaks commented Jan 31, 2024 •
edited
Loading

Hello @psavery! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-01-31 18:57:10 UTC

@psavery
Add single rmat multiple gvec, and rotation test
ab3749f 
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
ZackAttack614
ZackAttack614 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@ZackAttack614 ZackAttack614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify some of the calculations here one day. Should we get around to it.

@psavery psavery merged commit 5395b4b into master Jan 31, 2024
6 checks passed
@psavery psavery deleted the test-gvec-to-xy branch January 31, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackAttack614 ZackAttack614 ZackAttack614 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psavery @pep8speaks @ZackAttack614