Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hedm_intensity to PlaneData #619

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Add hedm_intensity to PlaneData #619

merged 3 commits into from
Mar 6, 2024

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Mar 4, 2024

This is computed nearly the same way as the powder intensity, except that it does not include multiplicity.

This PR also moves the lorentz and polarization functions to the crystallography module, where they are now used for computing the powder and HEDM intensities.

This is computed nearly the same way as the powder intensity, except that
it does not include multiplicity.

This PR also moves the lorentz and polarization functions to the
crystallography module, where they are now used for computing the
powder and HEDM intensities.

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
@psavery psavery requested a review from saransh13 March 4, 2024 18:28
psavery added a commit to HEXRD/hexrdgui that referenced this pull request Mar 4, 2024
This is computed nearly the same way as the powder intensity, except
that it does not include multiplicity. It is particularly useful for
rotation series data.

Fixes: #1664
Depends on: HEXRD/hexrd#619

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Copy link
Member

@saransh13 saransh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
@psavery psavery force-pushed the hedm-intensity branch 2 times, most recently from f26ca72 to 47f683b Compare March 6, 2024 21:34
python3.12 is causing some issues...

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
@psavery
Copy link
Collaborator Author

psavery commented Mar 6, 2024

Finally got the Linux packaging fixed 🙂

@psavery psavery merged commit 31ada96 into master Mar 6, 2024
6 checks passed
@psavery psavery deleted the hedm-intensity branch March 6, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants