Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation via Websocket differs from validation via command line #95

Closed
JWahle opened this issue Feb 22, 2021 · 4 comments
Closed

Validation via Websocket differs from validation via command line #95

JWahle opened this issue Feb 22, 2021 · 4 comments

Comments

@JWahle
Copy link
Contributor

JWahle commented Feb 22, 2021

It seems that validation via websocket is different from validation via command line.
The following config/coeff files are valid via command line but invalid when checked via the web interface (which uses the web socket for validation).
broken-validation.txt
Filter-44100-2.txt

I think this config should also be valid via websocket.

@HEnquist
Copy link
Owner

I looked i to this and yes there is a mistake in the config handling that causes the validation via websocket to skip the substitution step. Will fix!

@HEnquist
Copy link
Owner

I pushed a fix for this to develop just now. Can you try it?

@JWahle
Copy link
Contributor Author

JWahle commented Feb 22, 2021

Nice - works like a charm.
Adding a typo or changing the samplerate invalidates the cfg. Otherwise it is now valid.

@JWahle JWahle closed this as completed Feb 22, 2021
@bitkeeper
Copy link

Great, also the samplerate works as expected. As well cmd line, online and offline.
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants