Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error, if there is a missing samplerate/channels variant for any filter #10

Closed
JWahle opened this issue May 10, 2021 · 2 comments
Closed

Comments

@JWahle
Copy link

JWahle commented May 10, 2021

I think, it would be nice, if an error is reported, if there is a missing variant for any filter.
E.g. filter "left" has variants "left-44100-2.wav" & "left-48000-2.wav" and filter "right" has only one variant "right-44100-2.wav".
Then there would be a warning, that "right-48000-2.wav" is missing.

@HEnquist
Copy link
Owner

To implement this the validator has to loop through all filters twice.
On the first loop, it would check for files with all possible samplerates. This would result in a list of rates there is at least one file for. Then it would loop trough the filters again, and warn for those that don't support all those rates.
I'm not conviced this should be in the validator. It's already complicated enough, and I prefer to keep it as simple as possible to limit the number of mistakes.
I would suggest putting something in the backend, that gives a list of rates to the frontend. This list could then be shown in a tooltip or something:
44100: ok
48000: X
88200: ok
96000: X
etc (and ok should then be a checkmark).

@JWahle
Copy link
Author

JWahle commented May 10, 2021

Okay, I'll try an implementation in the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants