add supplydelivery stage and profiles #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmckenzi
reviewed
Sep 19, 2023
|
This was a branch to demo the concept and show that we don't need a
resource for a SupplyShipment and another for SupplyDelivery (which we can
if the WG wants), the PR was there to trigger the build.
Will check and update. Not sure about profiles - i guess we can put them in
an IG - but which? IHE is ready to do that if needed.
…On Tue, Sep 19, 2023 at 5:59 PM Lloyd McKenzie ***@***.***> wrote:
***@***.**** commented on this pull request.
Short seems wrong.
Also, why is condition a string and not a CodeableConcept?
You've added new profiles. We're trying to remove profiles from core. Are
they really needed in core? Could they live in an IG?
—
Reply to this email directly, view it on GitHub
<#2964 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3HUUBQ4NVYU77CPYZLN4LX3G6M7ANCNFSM6AAAAAA4HIBVKY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Ok, so this is something that's not to be merged then? |
|
Not yet, not before the WG decides what to do.
(is there a way to flag this?)
…On Tue, Sep 19, 2023 at 6:50 PM Lloyd McKenzie ***@***.***> wrote:
Ok, so this is something that's not to be merged then?
—
Reply to this email directly, view it on GitHub
<#2964 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3HUUGX6C33N53UMNSUVBDX3HEMJANCNFSM6AAAAAA4HIBVKY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Marked it as draft |
catch up with master
…ust introduction note to implementers accordingly. Change SupplyDelivery.stage data type from Coding to CodeableConcept.
rhausam
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HL7 FHIR Pull Request
Note: No pull requests will be accepted against
./sourceunless logged in the HL7 Jira issue tracker.If you made changes to any files within
./sourceplease indicate the Jira tracker number this pull request is associated with:Description
Please describe your pull request here.