Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appointment3 #101

Merged
merged 12 commits into from
Nov 25, 2021
Merged

Appointment3 #101

merged 12 commits into from
Nov 25, 2021

Conversation

lfreddy
Copy link
Contributor

@lfreddy lfreddy commented Nov 24, 2021

Thomas

Da har vi gjort oppdateringer.

@kennethmyhra
Copy link
Member

Hvis kodene (code) for no-basis-conference-type.codesystem er nyopprettede burde vi ikke da bruke engelsk språk? Display-verdiene som vises i ett grensesnitt kan og skal i mange tilfeller ha norske verdier.

Engelsk språk for de tekniske detaljene (attributter, koder, osv.) var i hvert fall ett prinsipp vi ble enige om for ganske mange år siden for å blant annet forenkle samarbeid med ikke-norske aktører.

Eksisterende (norske) kodeverk får man selvfølgelig ikke gjort noe med

@thomiz
Copy link
Member

thomiz commented Nov 24, 2021

Det er endel bugs her:

  1. Henvisningene til extensions i no-basis-Appointment profilen bruker feil canonical for å henvise til extensions.
  2. Extensions bør ha no-basis-[navn] både i id og url, for eksempel:
<id value="no-basis-conferencetype" />
<url value="http://hl7.no/fhir/structuredefinition/no-basis-conferencetype" />
  1. Det er også en merge conflict på no-basis-appointment-partof.md

Oppdatert url etter melding fra Thomas
@lfreddy
Copy link
Contributor Author

lfreddy commented Nov 24, 2021 via email

Oppdatert med no-basis på extensions. Oppdatert profiler med ny url.
Copy link
Member

@thomiz thomiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

@rockphotog rockphotog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thomas går selv god for dette!

…into Appointment3

# Conflicts:
#	input/no-basis-appointment-partof.md
@thomiz thomiz merged commit a433ed2 into master Nov 25, 2021
@thomiz thomiz deleted the Appointment3 branch November 25, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants