Implements #152 adds endpoint to list service capabilities #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolkalinski
commented
Nov 12, 2020
karolkalinski
commented
- new endpoint services/{serviceName}/versions/{version:.+}/capabilities/{protocol} created
- new endpoint CORS policy allows request from any domain: Access-Control-Allow-Origin: *
Pull Request Test Coverage Report for Build 611
💛 - Coveralls |
Felipe444
requested changes
Nov 16, 2020
| @ApiResponse(code = 200, message = "Success", response = ServiceContractsDto.class), | ||
| @ApiResponse(code = 400, message = "Bad Request"), | ||
| @ApiResponse(code = 500, message = "Failure")}) | ||
| public String getCapabilities( @PathVariable String serviceName, @PathVariable String version, @PathVariable(name = "protocol") String protocol) { |
There was a problem hiding this comment.
You should return contracts with their mime type as they are registered
There was a problem hiding this comment.
Endpoint modified to return mime type of a contract.
Felipe444
approved these changes
Nov 19, 2020
| return Optional.ofNullable(storage.get(serviceId)) | ||
| .flatMap {sc -> sc.getMappedCapabilities(protocol, {it -> it})} | ||
| .map{it -> it.getCapabilities() } | ||
| .flatMap{ it -> Optional.of(it.get(0)) } |
There was a problem hiding this comment.
can we make such assumption in the repository?
| @@ -99,6 +104,20 @@ public ServiceContractsDto getContracts(@PathVariable(name = "serviceName") Stri | |||
| return mapper.toDto(this.serviceContractsRepository.findOne(new ServiceId(serviceName, version)).orElseThrow(ResourceNotFoundException::new)); | |||
| } | |||
|
|
|||
| @GetMapping(value = "services/{serviceName}/versions/{version:.+}/capabilities/{protocol}", produces = MediaType.ALL_VALUE) | |||
| @CrossOrigin() | |||
There was a problem hiding this comment.
Please add it in a separate pull request and wherever applicable.
| @@ -7,12 +7,14 @@ | |||
| import com.hltech.judged.server.domain.contracts.ServiceContracts; | |||
| import com.hltech.judged.server.domain.contracts.ServiceContractsRepository; | |||
| import lombok.RequiredArgsConstructor; | |||
| import org.jetbrains.annotations.NotNull; | |||
There was a problem hiding this comment.
Is this jetbrains import required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.