Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jms comparator #63

Merged
merged 3 commits into from
May 8, 2019
Merged

Jms comparator #63

merged 3 commits into from
May 8, 2019

Conversation

Felipe444
Copy link
Collaborator

No description provided.

@Felipe444 Felipe444 requested a review from matek2305 May 8, 2019 08:40
@Felipe444 Felipe444 force-pushed the jms-comparator branch 4 times, most recently from f5be2cc to a195455 Compare May 8, 2019 10:00
@coveralls
Copy link

coveralls commented May 8, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 241

  • 53 of 71 (74.65%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.7%) to 93.06%
Changes Missing Coverage Covered Lines Changed/Added Lines %
judge-d-server/src/main/java/dev/hltech/dredd/domain/validation/jms/Capabilities.java 0 2 0.0%
judge-d-server/src/main/java/dev/hltech/dredd/domain/validation/jms/Expectations.java 0 2 0.0%
judge-d-server/src/main/java/dev/hltech/dredd/domain/validation/jms/Service.java 0 4 0.0%
judge-d-server/src/main/java/dev/hltech/dredd/domain/validation/jms/VauntValidator.java 18 22 81.82%
judge-d-server/src/main/java/dev/hltech/dredd/domain/validation/jms/JmsContractValidator.java 17 23 73.91%
Totals Coverage Status
Change from base Build 216: -2.7%
Covered Lines: 523
Relevant Lines: 562
💛 - Coveralls

@Felipe444 Felipe444 merged commit 3d45b9e into master May 8, 2019
@Felipe444 Felipe444 deleted the jms-comparator branch May 8, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matek2305 matek2305 matek2305 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Felipe444 @coveralls @matek2305