Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contracts endpoint unified #74

Merged
merged 3 commits into from
Aug 6, 2019
Merged

contracts endpoint unified #74

merged 3 commits into from
Aug 6, 2019

Conversation

karolkalinski
Copy link

We agreed to unified contracts endpoint in order to be RESTfull

@coveralls
Copy link

coveralls commented Aug 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 292

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 95.969%
Totals Coverage Status
Change from base Build 285: 0.1%
Covered Lines: 500
Relevant Lines: 521
💛 - Coveralls

Felipe444
Felipe444 requested changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator

@Felipe444 Felipe444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we be able to introduce this changes without any outage?

...-d-server/src/main/java/dev/hltech/dredd/domain/contracts/JpaServiceContractsRepository.java Show resolved Hide resolved
judge-d-server/src/main/java/dev/hltech/dredd/domain/contracts/ServiceContractsRepository.java Outdated Show resolved Hide resolved
judge-d-server/src/main/java/dev/hltech/dredd/domain/contracts/ServiceContractsRepository.java Outdated Show resolved Hide resolved
...e-d-server/src/main/java/dev/hltech/dredd/interfaces/rest/contracts/ContractsController.java Show resolved Hide resolved
@karolkalinski karolkalinski merged commit 452c827 into master Aug 6, 2019
@Felipe444 Felipe444 deleted the contracts-endpoint-unified branch June 15, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felipe444 Felipe444 Felipe444 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karolkalinski @coveralls @Felipe444