Write service representation to file as json. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlicsauce
reviewed
Apr 19, 2019
|
|
||
| def 'should write json file with service name, expectations and capabilities to target directory'() { | ||
| given: | ||
| def packageName = 'dev.hltech.transferout.informationrequest' |
There was a problem hiding this comment.
truly real-life example xD
There was a problem hiding this comment.
let's change it to something different
garlicsauce
approved these changes
Apr 19, 2019
Felipe444
requested changes
Apr 20, 2019
build.gradle
Outdated
| @@ -43,6 +43,7 @@ subprojects { | |||
|
|
|||
| testCompile "org.spockframework:spock-core:$spockVersion" | |||
| testCompile "org.codehaus.groovy:groovy-all:$groovyAllVersion" | |||
| testRuntimeOnly "net.bytebuddy:byte-buddy:1.9.12" | |||
There was a problem hiding this comment.
let's keep versions in one place
vaunt-generator/build.gradle
Outdated
| @@ -9,6 +9,9 @@ buildscript { | |||
|
|
|||
| dependencies { | |||
| compile "org.reflections:reflections:$reflectionsVersion" | |||
| compile "com.fasterxml.jackson.datatype:jackson-datatype-guava:$jacksonVersion" | |||
|
|
|||
| testCompile 'com.jayway.jsonpath:json-path-assert:2.2.0' | |||
| import java.io.IOException; | ||
| import java.nio.file.Paths; | ||
|
|
||
| @RequiredArgsConstructor | ||
| public class VauntGenerator { |
There was a problem hiding this comment.
Let's make VauntGenerator an orchestrator, i. e. firstly it calls RepresentationExtractor, later it calls VauntWriter; or something similar.
|
|
||
| def 'should write json file with service name, expectations and capabilities to target directory'() { | ||
| given: | ||
| def packageName = 'dev.hltech.transferout.informationrequest' |
There was a problem hiding this comment.
let's change it to something different
matek2305
force-pushed
the
write-vaunt-file
branch
from
33b57df
to
079212a
Compare
…ion and write to file.
matek2305
force-pushed
the
write-vaunt-file
branch
from
079212a
to
d6fd892
Compare
|
Please add task to create custom exceptions policy. |
Felipe444
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.