-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple server #89
Conversation
6f12f2c
to
c25d304
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thank you! 🚀
Can you fix the CI errors? They mainly deal with missing docs and some minor nitpicking from clippy. You should be able to reproduce most of these with cargo clippy
.
2b236ec
to
a8f19d6
Compare
Can you fix the remaining errors before we merge this? |
:) feels like more errors than added lines of code. Yes, I'll look into it. Thx |
We have agreed on applying aggressive linting rules regarding both code and documentation. Rust gives us the tools and we are using them. Should hopefully pay off in the long term 😅 |
Totally agree. The first time is always some hard but after getting used to it, I guess it is no big deal any more. |
812283d
to
b68c649
Compare
Installing and running pre-commit locally will reduce the feedback times. Our .justfile contains the required commands in the |
b68c649
to
736d710
Compare
736d710
to
1b72ebd
Compare
I've pushed a few more things to this to make the simple server be a little bit more useful. Note, that I'm not the advanced Rust dev yet, so chances are high, that I do things wrong here from a Rust point of view or that I did something which is not how you intended to be done. |
What is the idea behind the package |
1b72ebd
to
25a7cc7
Compare
The idea is that the types in the On the other hand, the non- That being said, the distinction is not as clear as it should be: some of the methods or rather free helper functions from |
The functionality for starting a simple server is added. It is not possible yet with to also add nodes. Only a empty server is started which can be connected to.
25a7cc7
to
72cbf2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the improvements! 🎉
## Description This cleans up some of the data structures introduced in #89, fixing issues where ownership passed into the C library where it was not expected, potentially leaking memory. See the individual commits in the PR for details.
The functionality for starting a simple server is added. It is not possible yet with to also add nodes. Only a empty server is started which can be connected to.