Split server type to allow mutations while running #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgoll
force-pushed
the
split-server-type
branch
2 times, most recently
from
f274b2a
to
c90ce40
Compare
sgoll
force-pushed
the
split-server-type
branch
from
c90ce40
to
45df8d3
Compare
uklotzde
previously approved these changes
Apr 30, 2024
uklotzde
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR splits the
Servertype intoServerandServerRunner.1 The latter handles the server's event loop (and is consumed) while the former can be used to modify variable values from different threads while the server is running.Footnotes
Feel free to suggest better names. ↩