Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new version of DecimalMath that supports multiple decimals base #230

Merged
merged 5 commits into from
Feb 27, 2020

Conversation

uivlis
Copy link
Contributor

@uivlis uivlis commented Feb 27, 2020

Fixes #227.

@uivlis uivlis requested a review from alcueca February 27, 2020 12:38
Copy link
Contributor

@alcueca alcueca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, only a few changes in the README and comments.

contracts/math/README.md Outdated Show resolved Hide resolved
contracts/math/README.md Outdated Show resolved Hide resolved
contracts/math/README.md Outdated Show resolved Hide resolved
contracts/math/DecimalMath.sol Outdated Show resolved Hide resolved
@uivlis uivlis requested a review from alcueca February 27, 2020 13:39
Copy link
Contributor

@alcueca alcueca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alcueca alcueca merged commit 5e39ae9 into master Feb 27, 2020
@alcueca alcueca deleted the new/decimal-math-v2 branch March 3, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiple base support to DecimalMath.sol
2 participants