ROLE_CIDE_ICZ Data entering control

[MartinTuchyna]

There is no control when SMS criteria are actually finished. Inspector can change it whenever he wants. This should not be possible.

Note 14.6.2019. Information required if it is possible to have information when SMS is finished.

[klimeto]

@MartinTuchyna why do you place the ROLE_CIDE_ICZ in the title? Is it an issue linked only to this role? If not remove it from the title!

Inspector can change / add scores until he / she finished the inspection, so naturally he / she can change them whenever.

If you wish to have a locking mechanisms for this, it is out of scope of the CIDE APP specification!

[MartinTuchyna]

@klimeto
The title ROLE_CIDE_ICZ was copied from the TIS_CIDE_GitHub_final.docx document provided by the testers in order to easily identify the original issue.
Not sure, if it is related only to this role, as I could not test this role. This shall be confirmed by the author of the issue.

[klimeto]

@MartinTuchyna

I kindly asked you not only to copy but also to test, verify and describe the real issue.
You can create any user of any role with your admin user!

[MartinTuchyna]

As already written, where I was able to test the issue - i have tried to do so. I was not aware of this option. When trying to create the user which role from the list in snap bellow refers to the "ROLE_CIDE_ICZ" ?

[MartinTuchyna]

OK, i manage to find that role - it was the last one Protection.

[MartinTuchyna]

When I logged in with ROLE_CIDE_ICZ I could not control SMS criteria at all.
Should not be possible only for the coordinator role?

[klimeto]

You can control criteria only for those CI which have SI of the protection type, because you logged as protection inspector. Now it should be possible because I fixed this issue #65

Vyrobil som SI Protection pre ES BP Dugo Selo potom nalogoval s klimeto_pr, ktory ma rolu ROLE_CIDE_ICZ a viem editorvat score aj poznamky:

IT works well after the fix in #65.