Fixed link checker #1574
Merged
Fixed link checker #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a custom container, use the base Ubuntu release and the GH actions needed to setup ruby, install Jekyll and then run it.
Simplify Gemfile
Change site.name to site.title and also update description
hegner
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link checker is fixed! I have updated it to not use a container, but to instead use the
ruby/setupaction running on the defaultubuntu-latestGitHub platform. This frees us from the obligation to maintain our own container and keep it up to date with Jekyll and ruby versions.The link checker configuration itself is unchanged, but has been tested by deliberately injecting some bad links on which it properly failed.
Closes #1559.