Warn if monitored process walltime is very short #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the wallclock time of the monitored process is very short then the averages calculated will not be very reliable, due to sampling effects. At least print a warning in that case.
graeme-a-stewart
force-pushed
the
wtime-warn
branch
from
c2d46fd
to
5fb6401
Compare
amete
approved these changes
Sep 3, 2020
|
Thanks a lot Graeme, this looks good. Now that we're increasing the number of messages, I think it would be nice push #106. Currently, either turning on/off debugging or deciphering where the errors are actually coming from might be a bit challenging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the wallclock time of the monitored process is
very short then the averages calculated will not
be very reliable, due to sampling effects. At least
print a warning in that case.
Closes #165