Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented simple monitor disabling #178

Merged
merged 6 commits into from
Nov 23, 2020
Merged

Implemented simple monitor disabling #178

merged 6 commits into from
Nov 23, 2020

Conversation

graeme-a-stewart
Copy link
Member

@graeme-a-stewart graeme-a-stewart commented Nov 20, 2020

Added new switch, --disable/-d that allows
monitors to be disabled. Switch can be given
multiple times to disable several components.

Validity of component name is checked and
walllmon cannot be disabled.

Added a new test to ensure that the switch
fucntions correctly.

README.md and help text updated.

Closes #107

graeme-a-stewart and others added 2 commits November 20, 2020 12:30
Added new switch, --disable/-d that allows
monitors to be disabled. Switch can be given
multiple times to disable several components.

Validity of component name is checked and
walllmon cannot be disabled.

Added a new test to ensure that the switch
fucntions correctly.

README.md and help text updated.
@graeme-a-stewart
Copy link
Member Author

There seems to be an issue with our build actions due to a GH security fix. I'll follow up on that.

@graeme-a-stewart
Copy link
Member Author

graeme-a-stewart commented Nov 20, 2020

I think the codefactor warning can be ignored in this case (it's what we used for ages and injecting a bogus "pstree" into the PATH would just cause prmon to break. (Plus it's the old method, that at some point we can drop.)

Copy link
Collaborator

@amete amete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @graeme-a-stewart. The new functionality looks good to me. I have just a few minor comments.

package/src/prmonutils.cpp Outdated Show resolved Hide resolved
package/tests/CMakeLists.txt Outdated Show resolved Hide resolved
@amete
Copy link
Collaborator

amete commented Nov 23, 2020

I resolved the simple conflict through the web interface and the associated CI passed (although not posted above due to clang-format interfering):

https://github.com/HSF/prmon/actions/runs/378656295

We agree to ignore the CodeFactor error for the time being. Therefore, I'm merging this now. Many thanks @graeme-a-stewart.

@amete amete merged commit 3cb5c22 into master Nov 23, 2020
@amete amete mentioned this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Options to enable/disable monitoring components
2 participants