Added command line switches to control logging level of monitors #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme-a-stewart
requested changes
Jul 21, 2021
There was a problem hiding this comment.
Thanks @quantum-shift - really works very much as I expected. Just a few small issues to fix before merging this one.
quantum-shift
force-pushed
the
spdlog_logger
branch
2 times, most recently
from
23a00b5
to
61e405c
Compare
Global logging level can also be set Updated README.md to include new command line switch and cloning instructions
quantum-shift
force-pushed
the
spdlog_logger
branch
from
61e405c
to
ff58c1e
Compare
|
Thank you for your comments, @amete and @graeme-a-stewart. I have made the changes. Please have a look. |
graeme-a-stewart
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command line switches
--level LEVand--level MON:LEVhave been added. These can be used to set the minimum global logging level as well as minimum logging level for individual monitors.The README has been updated to include cloning instructions (
--recurse-submodules) as prmon now includes spdlog submodule. The new command line options have also been updated in the README.Closes #189, closes #106.