Fixed netmon initialisation bug #199 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantum-shift
force-pushed
the
netdevs-bug
branch
from
36db0cb
to
33a8b58
Compare
quantum-shift
force-pushed
the
netdevs-bug
branch
from
33a8b58
to
81657ab
Compare
graeme-a-stewart
approved these changes
Aug 27, 2021
|
Thanks @quantum-shift - nice fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #199,
netmonis always initialised with the default constructor since the introduction of registry. This is fixed by introducing a new registry macro for registering a subclass with a single argument constructor.netmonis now initialised with a constructor taking a vector of network devices as input. The network devices passed as arguments in the CLI are passed to the constructor.Closes #199.