Update Python scripts to Python3 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change from the Python2/3 compatible scripts to ones that use Python3 features (mainly use of Python f-strings, which are faster and easier to understand). Fix the precook_test.py script with a shebang.
Black doesn't split long strings - this has to be done "by hand". Fixed a missing f-string indicator
amete
requested changes
Sep 22, 2021
There was a problem hiding this comment.
Thanks a lot @graeme-a-stewart. Your changes look good to me, modulo two typos.
Co-authored-by: Alaettin Serhan Mete <serhanmete@gmail.com>
Thanks for spotting those (it's an annoyingly manual process - I didn't find a tool that would do it) |
It seems as if there is a tool called flynt that does this but I haven't used it myself. |
amete
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from the Python2/3 compatible scripts to ones that
use Python3 features (mainly use of Python f-strings, which are
faster and easier to understand).
Fix the precook_test.py script with a shebang.
Scripts were re-blacked as well.
Closes #202