Fix wallclock units #206
Merged
Fix wallclock units #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the transition to the parameter value class the wallclock monitor now stores values internally in seconds, not in clock ticks. This lead to a wrong comparison for the short wallclock warning. In addition to fixing the test, the method is renamed to avoid confusion.
|
I found a very minor bug when testing #205 - fixed here. |
quantum-shift
approved these changes
Oct 6, 2021
amete
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the transition to the parameter value class
the wallclock monitor now stores values internally
in seconds, not in clock ticks. This lead to a wrong
comparison for the short wallclock warning.
In addition to fixing the test, the method is renamed
to avoid confusion.