Clang fixes #212
Merged
Clang fixes #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy up a few unused variables spotted by clang Correct the uniform initialiser for testing Add the -fno-builtin flag when using clang for tests to ensure that the VMEM values are not optimised out of bounds for the test setup
graeme-a-stewart
added
bug
amete
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few issues found with clang compilation:
Also prevent clang for optimising
malloc()when running the memory usage test, as this messes with the VMEM figures and causes the tests to fail.With this patch the clang build and all tests (inc. Gtests) compile and run successfully.
Closes #210