Add source release action #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the GitHub source archives do not contain any submodules they are not very useful for people wishing to build a released version of prmon. This action should build a source release archive with resursion switched on at checkout, so that spdlog will be included correctly.
|
Hi Serhan - in principle this should fix #209, but I am trying to think how to think if there's a way to test it without making half a dozen dummy releases. |
Change unpacked directory to be prmon-VERSION Tarball itself is just VERSION.tar.xz
amete
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Looks good, thanks a lot @graeme-a-stewart. Let's see how this behaves w/ the next release.
|
I think the unpacked directory name is going to be very slightly different, viz,. |
|
I think it's more of a convention than anything else. Therefore, I don't think it'll be a problem but we'll know for sure when we try to do a full deployment 😄 |
|
Thanks a lot! I tried it in my fork and it seemed to work fine 🙂 |
|
Thanks a lot for checking @nikoladze ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the GitHub source archives do not contain any
submodules they are not very useful for people
wishing to build a released
version of prmon. This action should build a source release
archive with resursion switched on at checkout, so that
spdlog will be included correctly.
Closes #209