Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the empty netmon description in the help message #227

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

amete
Copy link
Collaborator

@amete amete commented Feb 24, 2023

Hi @graeme-a-stewart,

I noticed that the description for netmon in the help message is empty:

Monitors available:
 - countmon : Monitor number of processes and threads
 - cpumon : Monitor cpu time used
 - iomon : Monitor input and output activity
 - memmon : Monitor memory usage
 - nvidiamon : Monitor NVIDIA GPU activity
 - wallmon : Monitor wallclock time
 - netmon : 

More information: https://github.com/HSF/prmon

This PR should fix it:

Monitors available:
 - countmon : Monitor number of processes and threads
 - cpumon : Monitor cpu time used
 - iomon : Monitor input and output activity
 - memmon : Monitor memory usage
 - nvidiamon : Monitor NVIDIA GPU activity
 - wallmon : Monitor wallclock time
 - netmon : Monitor network activity (device level)

More information: https://github.com/HSF/prmon

Please let me know what you think, many thanks.

Best,
Serhan

Copy link
Member

@graeme-a-stewart graeme-a-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted @amete. I really do hate these templated monitor codes, however, it seems to be a necessary evil in C++!

@graeme-a-stewart graeme-a-stewart merged commit 46fbc5b into main Apr 11, 2023
@graeme-a-stewart graeme-a-stewart deleted the main-fix-netmon-help-message branch April 11, 2023 09:36
@graeme-a-stewart
Copy link
Member

Sorry, I overlooked this for so long!

@amete
Copy link
Collaborator Author

amete commented Apr 11, 2023

No worries @graeme-a-stewart, it's a minor thing in any case, thanks a lot 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants