fix: 修改 課前詢問、評分回傳資訊 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperhsiaooo
requested changes
Jun 5, 2023
There was a problem hiding this comment.
@ankazu
不太理解「須留意之後重構需把表內而外新增的 date、name 移除」這句話的意思，可以敘述一下問題點嗎？
src/js/formatDate.js
Outdated
Comment on lines
1
to
16
| function formatDate(date) { | ||
| const formattedDate = new Date(date).toLocaleString('zh-TW', { | ||
| year: 'numeric', | ||
| month: '2-digit', | ||
| day: '2-digit', | ||
| hour: '2-digit', | ||
| minute: '2-digit', | ||
| hour12: false | ||
| }) | ||
|
|
||
| return formattedDate | ||
| } | ||
|
|
||
| module.exports = { | ||
| formatDate | ||
| } |
There was a problem hiding this comment.
在 utils 下有個 format.js，將所有 format 相關的 function 集中於那邊會比較適合
| } | ||
| ] | ||
| }) | ||
| classInquiryData.sort((a, b) => a.id - b.id) | ||
|
|
||
| console.dir(classInquiryData) |
|
「須留意之後重構需把表內而外新增的 date、name 移除」只是多餘的欄位可以考慮移除而已 |
ankazu
commented
Jun 5, 2023
| } | ||
| ] | ||
| }) | ||
| classInquiryData.sort((a, b) => a.id - b.id) | ||
|
|
||
| console.dir(classInquiryData) |
src/js/formatDate.js
Outdated
Comment on lines
1
to
16
| function formatDate(date) { | ||
| const formattedDate = new Date(date).toLocaleString('zh-TW', { | ||
| year: 'numeric', | ||
| month: '2-digit', | ||
| day: '2-digit', | ||
| hour: '2-digit', | ||
| minute: '2-digit', | ||
| hour12: false | ||
| }) | ||
|
|
||
| return formattedDate | ||
| } | ||
|
|
||
| module.exports = { | ||
| formatDate | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改 課前詢問與 userId 關聯，評分 date 調整
新增 回傳別名，頭像，時間
須留意之後重構需把表內而外新增的 date、name 移除