Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修改 課前詢問、評分回傳資訊 #21

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

ankazu
Copy link
Contributor

@ankazu ankazu commented Jun 5, 2023

修改 課前詢問與 userId 關聯,評分 date 調整
新增 回傳別名,頭像,時間
須留意之後重構需把表內而外新增的 date、name 移除

@ankazu ankazu requested a review from paperhsiaooo June 5, 2023 11:58
Copy link
Contributor

@paperhsiaooo paperhsiaooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankazu
不太理解「須留意之後重構需把表內而外新增的 date、name 移除」這句話的意思,可以敘述一下問題點嗎?

Comment on lines 1 to 16
function formatDate(date) {
const formattedDate = new Date(date).toLocaleString('zh-TW', {
year: 'numeric',
month: '2-digit',
day: '2-digit',
hour: '2-digit',
minute: '2-digit',
hour12: false
})

return formattedDate
}

module.exports = {
formatDate
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在 utils 下有個 format.js,將所有 format 相關的 function 集中於那邊會比較適合

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

}
]
})
classInquiryData.sort((a, b) => a.id - b.id)

console.dir(classInquiryData)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.dir 需移除

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ankazu
Copy link
Contributor Author

ankazu commented Jun 5, 2023

「須留意之後重構需把表內而外新增的 date、name 移除」只是多餘的欄位可以考慮移除而已

@ankazu ankazu requested a review from paperhsiaooo June 5, 2023 12:16
Copy link
Contributor Author

@ankazu ankazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以修改

}
]
})
classInquiryData.sort((a, b) => a.id - b.id)

console.dir(classInquiryData)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Comment on lines 1 to 16
function formatDate(date) {
const formattedDate = new Date(date).toLocaleString('zh-TW', {
year: 'numeric',
month: '2-digit',
day: '2-digit',
hour: '2-digit',
minute: '2-digit',
hour12: false
})

return formattedDate
}

module.exports = {
formatDate
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Contributor

@paperhsiaooo paperhsiaooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLTM!

@ankazu ankazu merged commit 15d6bf4 into develop Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants