Guard against calling gemv! with empty output
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was made an error in JuliaLang/julia#41513. Obviously, the `gemv!` call can just be omitted if the output is empty anyway.
martinholters
changed the title
gemv! with empty outputgemv! with empty output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was made an error in JuliaLang/julia#41513. It would be re-enabled by JuliaLang/julia#42012 or JuliaLang/julia#42054, but obviously, the
gemv!call can just be omitted if the output is empty anyway. So while this change might turn out not to be required in the long run, it surely doesn't hurt. (And might even buy a little bit of performance for the trivial cases by avoiding unnecessary call overhead while the cost of the extra checks should not matter in non-trivial cases.)