Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2345 AllReady.ScenarioTest Issues #2350

Closed
wants to merge 10 commits into from
Closed

Fixes #2345 AllReady.ScenarioTest Issues #2350

wants to merge 10 commits into from

Conversation

oneolddev
Copy link
Collaborator

@oneolddev oneolddev commented Feb 23, 2019 •
edited
Loading

WIP for #2345

Attempting to address issues specific to the integration test.

@oneolddev oneolddev mentioned this pull request Feb 23, 2019
Open
@oneolddev
Copy link
Collaborator Author

Using this pull request to test

  1. Migration of integration test to core 2.1 and Canopy 2.0
  • The original implementation of the integration test used a very old version of Canopy. There have been multiple bug fixes to that original version. It was also implemented in .net 4.61. Moving this to Core 2.1 should make these tests runnable on non-windows platforms.
  1. Build process in AppVeyor
  • Changes to the yml file was necessary to run tests in AppVeyor. There is no way to test this locally.

The PR is not intended to be merged.

@oneolddev
Copy link
Collaborator Author

Please see #2352.

Aggregated this work into #2352. There were too many linkages with other issues.

Closing this PR.

@oneolddev oneolddev closed this Mar 14, 2019
@oneolddev oneolddev deleted the issue_branch_2345 branch March 20, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oneolddev