Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

include href attribute for SRI custom metric #194

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

tomvangoethem
Copy link
Contributor

<link> elements can have SRI, but use a href attribute to point to the resource

Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this mean the August data is incorrect?

@tomvangoethem
Copy link
Contributor Author

There's still the data for <script> elements, which have the src attribute (which make up the majority of elements using SRI), so it's not that much of an issue.
I queried just the script elements here

@rviscomi
Copy link
Member

rviscomi commented Oct 5, 2020

Sounds good. Be aware that the October crawl has already started, so the link[href] data won't be in before the November crawl, which will be queryable in December. So I hope you're not waiting on it for the 2020 Almanac 😁

@rviscomi rviscomi merged commit 4b61a6a into HTTPArchive:master Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants