Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong MEX dimension calculation for unshared offsets with negative values #11

Closed
orsharir opened this issue Jun 4, 2017 · 0 comments
Closed

Wrong MEX dimension calculation for unshared offsets with negative values #11

orsharir opened this issue Jun 4, 2017 · 0 comments
Assignees
@elhanan7
Labels
bug

Comments

@orsharir
Copy link
Member

orsharir commented Jun 4, 2017

I've just noticed that you've got a minor bug (starting at this line)[https://github.com/HUJI-Deep/simnets-tf/blob/559663bf60a647f232e81adc3692c40cf473d661/src/mex_kernel_common.cpp#L98]. Instead of 1 it should be equal to the respective dimension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elhanan7 elhanan7

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orsharir @elhanan7