Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in cargo::rerun-if-changed #1077

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julianschuler
Copy link
Member

@julianschuler julianschuler commented Jun 24, 2024

Why? What?

This PR changes cargo:rerun-if-changed to the new cargo::rerun-if-changed notation.

See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script.

ToDo / Known Issues

This requires at least rust 1.77, so this is blocked until we have updated everything to at least 1.77.

Ideas for Next Iterations (Not This PR)

None.

How to Test

Build it.

@julianschuler julianschuler added is:Bug This is a bug and should be prioritised. GO24 labels Jun 24, 2024
@julianschuler julianschuler added cat:Framework RC24 and removed GO24 is:Bug This is a bug and should be prioritised. labels Jun 24, 2024
@oleflb oleflb self-assigned this Jun 29, 2024
Copy link
Contributor

@oleflb oleflb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but we need a newer rust version in the SDK in order for the CI to green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants